Quote: Show

I have installed and tested your mod which works exactly as I expected. Unfortunately I have found a bug, causing some error messages at least with PHP 5.1;

weberho wrote: Show

The problem I have had was, that in the two lines

Code:

    $temp_userdata = get_userdata($row['user_id']);

the $row['user_id'] variable is no initialized.

I have now moved the two sections

Code:

 $temp_userdata = get_userdata($row['user_id']);
 $temp_is_auth = auth(AUTH_ALL, $forum_id, $temp_userdata, -1);
 // another security check (i.e. the forum might have become private and 
// there are still users who have notification activated)
 if( $temp_is_auth['auth_read'] && $temp_is_auth['auth_view'] )

into the section

Code:

 for ($i = 0; $i < count($bcc_list); $i++)
 {
   $emailer->bcc($bcc_list[$i]);
 }

As result, the existing "if( $temp_is_auth['auth_read'] && $temp_is_auth['auth_view'] )" structure has been removed and the for-section is replaced by:

Code:

 for ($i = 0; $i < count($bcc_list); $i++)
 {
   $temp_userdata = get_userdata($users_ary[$bcc_list[$i]]);
   $temp_is_auth = auth(AUTH_ALL, $forum_id, $temp_userdata, -1);
   // another security check (i.e. the forum might have become private and    // there are still users who have notification activated)
   if( $temp_is_auth['auth_read'] && $temp_is_auth['auth_view'] )
     {
       $emailer->bcc($bcc_list[$i]);
     }
 }

I'm not completely sure, if this coded does exactly what you have been expected (check forum's visibility for every receipient), but I think it does;